Fix failing release CI #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charmcraft bug causes check-lib check to fail canonical/charmcraft#1389 (comment)
carlcsaposs-canonical
force-pushed
the
fix-failing-release
branch
from
561d59b
to
0caaf5d
Compare
paulomach
reviewed
Jan 8, 2024
.github/workflows/release.yaml
Outdated
| pipx install tox | ||
| pipx install poetry | ||
| tox run -e build-wrapper | ||
| mv requirements-last-build.txt requirements.txt |
There was a problem hiding this comment.
Does requirements.txt need to be populates at all, or just exist?
There was a problem hiding this comment.
good point; empty file seems to work
taurus-forever
approved these changes
Jan 8, 2024
paulomach
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charmcraft bug causes check-lib check to fail
canonical/charmcraft#1389 (comment)