Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Charm Action #38

Merged
merged 13 commits into from
Apr 29, 2022
Merged

Release Charm Action #38

merged 13 commits into from
Apr 29, 2022

Conversation

agathanatasha
Copy link
Contributor

@agathanatasha agathanatasha commented Apr 4, 2022

Release action releases a revision or a revision given the track/risk channel name to a specified destination channel.
If both revision and origin channel are filled in, revision number takes precedent.
It finds the revision number of a channel by parsing the output of charmcraft status.
It parses the combination of resources versions from github releases. Therefore, the charm must use upload-charm action to publish.
After releasing to charmcraft, it updates the github release of that revision with the destination channel and a timestamp. The line would be added at the end of the release body before the github generated changelog.
e.g. Released to 'latest/candidate' at 21:10 UTC on 5 Apr 2022

Limitations:
This action doesn't work with charm that support multiple bases.
The origin channel must be in the format of track/risk for parsing the charmcraft status output.
This action is only individual charms. It does not support releasing bundles.
It does not support charm with channel branches as it would mess up the charmcraft status output.

@agathanatasha agathanatasha marked this pull request as ready for review April 6, 2022 13:51
Copy link
Member

@simskij simskij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is awesome! Thank you! I do, however, have some comments that I'd like us to discuss prior to accepting it.

release-charm/README.md Outdated Show resolved Hide resolved
src/actions/release-charm/helpers.ts Outdated Show resolved Hide resolved
@simskij
Copy link
Member

simskij commented Apr 19, 2022

We had a call today to try to iron out how to proceed with this one. The conclusion we've arrived at is:

  1. We're only gonna allow promoting revisions already in a channel.
  2. We need to switch the resource revision fetch from using the git tags to using charmcraft status

Thanks again for all the input!

release-charm/README.md Outdated Show resolved Hide resolved
release-charm/README.md Outdated Show resolved Hide resolved
@simskij simskij merged commit b01573c into main Apr 29, 2022
@simskij simskij deleted the promote-charm branch April 29, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants