-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Charm Action #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charmcraft.metadata() would fail if metadata.yaml is not in the current directory update readme with more information
agathanatasha
requested review from
simskij,
DomFleischmann,
ca-scribner,
DnPlas and
natalian98
April 6, 2022 13:51
simskij
requested changes
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is awesome! Thank you! I do, however, have some comments that I'd like us to discuss prior to accepting it.
We had a call today to try to iron out how to proceed with this one. The conclusion we've arrived at is:
Thanks again for all the input! |
simskij
reviewed
Apr 20, 2022
simskij
reviewed
Apr 29, 2022
simskij
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release action releases a revision or a revision given the
track/risk
channel name to a specified destination channel.If both revision and origin channel are filled in, revision number takes precedent.
It finds the revision number of a channel by parsing the output of
charmcraft status
.It parses the combination of resources versions from github releases. Therefore, the charm must use
upload-charm
action to publish.After releasing to charmcraft, it updates the github release of that revision with the destination channel and a timestamp. The line would be added at the end of the release body before the github generated changelog.
e.g.
Released to 'latest/candidate' at 21:10 UTC on 5 Apr 2022
Limitations:
This action doesn't work with charm that support multiple bases.
The origin channel must be in the format of
track/risk
for parsing the charmcraft status output.This action is only individual charms. It does not support releasing bundles.
It does not support charm with channel branches as it would mess up the charmcraft status output.