Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel doesn't have 'static' it has 'none' #138

Closed
wants to merge 4 commits into from
Closed

Kernel doesn't have 'static' it has 'none' #138

wants to merge 4 commits into from

Conversation

donnydavis
Copy link

This PR will fix cloud-init looking for the kernel to report back a value of static when it reports back none. This covers cases where there is no dhcp but users would still like to use cloud-init.

https://bugs.launchpad.net/cloud-init/+bug/1785275

This PR will fix cloud-init looking for the kernel to report back a value of static when it reports back none. This covers cases where there is no dhcp but users would still like to use cloud-init. 

https://bugs.launchpad.net/cloud-init/+bug/1785275
@blackboxsw
Copy link
Collaborator

Thank you so much for your contribution to cloud-init and for making cloud-init better!

Generally we like to see a few things to land changes and improvements to cloud-init:

  1. Travis continuous integration needs to succeed on your branch and
  2. Unit test coverage of your changes
  3. Signing the CLA

Contributions to cloud-init are governed by a Contributor License Agreement (CLA). Please confirm that you have signed the CLA per our hacking guide and run migrate-lp-user-to-github to associate this github account as someone who has signed the CLA.

@blackboxsw blackboxsw added the CLA not signed The submitter of the PR has not (yet) signed the CLA label Dec 25, 2019
@donnydavis
Copy link
Author

donnydavis commented Dec 30, 2019

Thank you so much for your contribution to cloud-init and for making cloud-init better!

Generally we like to see a few things to land changes and improvements to cloud-init:

  1. Travis continuous integration needs to succeed on your branch and
  2. Unit test coverage of your changes
  3. Signing the CLA

Contributions to cloud-init are governed by a Contributor License Agreement (CLA). Please confirm that you have signed the CLA per our hacking guide and run migrate-lp-user-to-github to associate this github account as someone who has signed the CLA.

Ok I signed the CLA and updated the unit tests. Apologies for the messy commits - used to git review

@donnydavis
Copy link
Author

Abandoning in favor of #148 - This patch is much cleaner and lighter

@donnydavis donnydavis closed this Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA not signed The submitter of the PR has not (yet) signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants