New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kernel doesn't have 'static' it has 'none' #148
Conversation
Credit for this patch kevindtimm@gmail.com https://launchpadlibrarian.net/385938425/0001-change-none-to-static-for-ip-address-in-GRUB_CMDLINE.patch Closes bug : https://bugs.launchpad.net/cloud-init/+bug/1785275 Abandon PR canonical#138 in favor of this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Is there something holding this patch from being merged? |
@donnydavis, yes: holidays. |
Thanks for this commit @donnydavis, as with your PR #138, please add unit tests And per your comment linked here #138 (comment) it sounds like you've signed the CLA. In order to track the accountability of that signature, we need to link your launchpad account name to your github name please run Ok I signed the CLA and updated the unit tests. Apologies for the messy commits - used to git review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the re-submit @donnydavis Needs unit test coverage and CLA signing
So do I need to write a separate unit test? Isn't the one that is already run sufficient? All this does is correct the behavior of the linux kernel passing 'none' when a static ip address is used. And if I run this migration from LP to github will it mess anything up with my launchpad acct or does it just link things? |
@donnydavis sorry I missed this response. The migrate-lp-to-github script only creates an identical pull request on luanchpad and github so we can validate you control both accounts (and then we can validated that the Launchpad user had indeed signed the CLA). It only adds a single documentation line into the file tools/.lp-to-git-user which contains your username mapping. It does no other work. We manually merge your pull request into the github project and move on with your PR reviews. |
@@ -127,6 +127,9 @@ def _klibc_to_config_entry(content, mac_addrs=None): | |||
else: | |||
proto = 'static' | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we instead make this an elif clause so we don't double check a proto that we just setup because it was absent?
elif proto == 'none': | |
proto = 'static' |
Here's the unit test I'd like to see which shows that cloud-init parses None. It may be nice to have a comment in either the unit test or at the place in net/cmdline where we are overriding 'none' to 'static'
|
I believe that this patch has been made obsolete by #201 landing, so I'm closing this out. Thanks for your contribution! |
happy to see this bug resolved |
Credit for this patch kevindtimm@gmail.com
https://launchpadlibrarian.net/385938425/0001-change-none-to-static-for-ip-address-in-GRUB_CMDLINE.patch
Closes bug : https://bugs.launchpad.net/cloud-init/+bug/1785275
Abandon PR #138 in favor of this one