Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read-version: When insufficient tags, use cloudinit.version.get_version #1912

Merged

Conversation

blackboxsw
Copy link
Collaborator

@blackboxsw blackboxsw commented Dec 14, 2022

Proposed Commit Message

read-version: When insufficient tags, use cloudinit.version.get_version

Additional Context

Test Steps

git clone --no-single-branch --depth 50 https://github.com/canonical/cloud-init.git
cd cloud-init
git fetch origin --force --tags --prune --prune-tags --depth 50 pull/1879/head:external-1879
git checkout --force ac0795a9ff76c48ca74ae23b5766543ef6785387
git apply <this patch>
./tools/read-version

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@TheRealFalcon
Copy link
Member

Can we instead use what's defined in version.py?

@blackboxsw blackboxsw force-pushed the rtd-read-ver-unshallow-when-needed branch from 596d52f to 6973ca9 Compare December 14, 2022 23:35
@blackboxsw blackboxsw changed the title read-version: When insufficient tags, git fetch --unshallow for RTD read-version: When insufficient tags, use cloudinit.version.get_version Dec 14, 2022
@blackboxsw
Copy link
Collaborator Author

Can we instead use what's defined in version.py?

I think that'll work too. Our only goal with this is to make tools/read-version more resilient in the face of a missing annotated tag.
I've updated the PR

@blackboxsw blackboxsw merged commit 6bdd88a into canonical:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants