BSD: find_devs_with_ refactoring #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
changed the title
igalic
reviewed
Apr 1, 2020
goneri
force-pushed
the
BSD-find_devs_with_-refactoring
branch
from
c8446d7
to
df56859
Compare
goneri
commented
Apr 2, 2020
| # Query optical drive to get it in blkid cache for 2.6 kernels | ||
| util.find_devs_with(path="/dev/sr0") | ||
| util.find_devs_with(path="/dev/sr1") | ||
| # Query optical drive to get it in blkid cache for 2.6 kernels |
There was a problem hiding this comment.
Is this still something useful?
goneri
changed the title
goneri
force-pushed
the
BSD-find_devs_with_-refactoring
branch
from
df56859
to
544f26e
Compare
goneri
force-pushed
the
BSD-find_devs_with_-refactoring
branch
from
544f26e
to
76e71f0
Compare
blackboxsw
requested changes
Apr 14, 2020
There was a problem hiding this comment.
looks good, thanks for the refactor @goneri. Minor nits mentioned inline.
goneri
force-pushed
the
BSD-find_devs_with_-refactoring
branch
from
76e71f0
to
c35884e
Compare
blackboxsw
reviewed
Apr 22, 2020
blackboxsw
reviewed
Apr 22, 2020
blackboxsw
requested changes
Apr 22, 2020
blackboxsw
requested changes
Apr 24, 2020
There was a problem hiding this comment.
+1 @goneri just a git rebase -i master and resolve a minor conflict now that your other branch landed.
Refactoring of the `find_devs_with_xxx()` methods: - centralize everything in `util.py` - add test coverage
goneri
force-pushed
the
BSD-find_devs_with_-refactoring
branch
from
b9ceace
to
0f4a189
Compare
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the
find_devs_with_xxx()methods:util.py