fix(dhcpcd): Make lease parsing more robust #5129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holmanb
force-pushed
the
holmanb/dhcpcd-robust-parsing
branch
from
915bcda
to
1ae918f
Compare
holmanb
force-pushed
the
holmanb/dhcpcd-robust-parsing
branch
from
1ae918f
to
aec9035
Compare
blackboxsw
requested changes
Apr 2, 2024
There was a problem hiding this comment.
Thanks for the improvement to avoid breakage. Can we also take this a step further to do the following:
- log in the ValueError handling the source dump_lease content for reference in the error-level logs
- raise an error when the processed dhcpcd.lease file has no viable parsed config options
|
Thanks for the review @blackboxsw. I think that I've addressed all of your comments. Requesting re-review. |
holmanb
force-pushed
the
holmanb/dhcpcd-robust-parsing
branch
from
92d91ec
to
0ef7ea8
Compare
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Apr 2, 2024
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Apr 2, 2024
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Apr 3, 2024
holmanb
added a commit
that referenced
this pull request
Apr 3, 2024
holmanb
added a commit
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Followup to #5128 (rebase before merge)
Merge type