Cloud specific binary packages #5655
Conversation
|
This PR requires #5637 to be merged and upstream released to really get rid of |
aciba90
force-pushed
the
cloud-specific-binary-packages
branch
3 times, most recently
from
65ba099
to
5ff63c9
Compare
|
I have updated this PR performing a new upstream release based on tip of main to include #5637. |
|
The ci check check-patches fails due to #5675. |
There was a problem hiding this comment.
Nice work! In general LGTM, though I think @blackboxsw and/or somebody from distro should review this too.
|
Many thanks for the feedback, @TheRealFalcon.
Could you, @basak, please take a look on this one? SC-1728 and US120 for context. |
aciba90
force-pushed
the
cloud-specific-binary-packages
branch
from
5ff63c9
to
2252c62
Compare
|
Force-pushed to add a |
aciba90
force-pushed
the
cloud-specific-binary-packages
branch
from
2252c62
to
a494644
Compare
|
^ This PR was in a wrong status. The MAAS handling was included in the |
aciba90
force-pushed
the
cloud-specific-binary-packages
branch
from
a494644
to
34700ec
Compare
There was a problem hiding this comment.
I'm seeing package upgrade issuse in postinst which point to inconsistencies in cloud-init w.r.t. a full package replacement of cloud-init-base from the original cloud-init package. I'm wondering if this is a case where we need to employ dpkg-divert here to avoid those file and directory conflicts.
Unpacking cloud-init-base (24.4~3+really24.3.1-0ubuntu5~ppa1) ...
dpkg: error processing archive /var/cache/apt/archives/cloud-init-base_24.4~3+really24.3.1-0ubuntu5~ppa1_all.deb (--unpack):
trying to overwrite '/etc/cloud/cloud.cfg', which is also in package cloud-init 24.4~3+really24.3.1-0ubuntu4
dmesg: read kernel buffer failed: Operation not permitted
dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)
Preparing to unpack .../cloud-init_24.4~3+really24.3.1-0ubuntu5~ppa1_all.deb ...
Unpacking cloud-init (24.4~3+really24.3.1-0ubuntu5~ppa1) over (24.4~3+really24.3.1-0ubuntu4) ...
dpkg: warning: unable to delete old directory '/etc/cloud/templates': Directory not empty
dpkg: warning: unable to delete old directory '/etc/cloud/cloud.cfg.d': Directory not empty
dpkg: warning: unable to delete old directory '/etc/cloud': Directory not empty
Errors were encountered while processing:
/var/cache/apt/archives/cloud-init-base_24.4~3+really24.3.1-0ubuntu5~ppa1_all.deb
needrestart is being skipped since dpkg has failed
34700ec
to
1c8e229
Compare
Add infrastructure to be able to express cloud-specific cloud-init binary packages. Rename cloud-init to cloud-init-base. This one will represent cloud-init plus the base dependency set. Add `Breaks:` and `Replaces:` dependency with cloud-init <= 24.4~2g2e4c39b7-0ubuntu1 to adopt and own files from cloud-init in cloud-init-base, see [1] for more context. Keep a cloud-init metapackage to install every possible dependency and be able to operate on any platform. SC-1854 US120 [1] https://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces
Add cloud-init-cloud-sigma and cloud-init-smart-os binary packages depending on cloud-init-base and python3-serial. Removes python3-serial from cloud-init-base and add it to cloud-init. Fixes SC-1854 US120
+ Add warning about image portability to dpkg-reconfigure Fixes SC-1855
aciba90
force-pushed
the
cloud-specific-binary-packages
branch
2 times, most recently
from
1c35ec1
to
5f75b35
Compare
|
Thanks, @blackboxsw, for the review. This issue you were facing happened because the cloud-init version of the I have updated https://launchpad.net/~aciba/+archive/ubuntu/us-120-cloud-specific-cloud-init-packaging to contain the latest changes from this PR, feel free to use it while testing this. I have addressed the rest of the concerns and this PR is ready to be reviewed again. |
aciba90
force-pushed
the
cloud-specific-binary-packages
branch
from
5f75b35
to
03ce0a5
Compare
Do not squash
See individual commits for more context and:
Additional Context
Test Steps
Merge type