Add wait-for-disk functionality to disk_setup (#1832645)

[nibalizer]

Proposed Commit Message

Add wait-for-disk functionality to disk_setup

In a cloud environment, sometimes disks will attach while cloud-init is
running and get missed. This adds a configurable timeout to wait for
those disks.

LP: #1832645

summary: no more than 70 characters

A description of what the change being made is and why it is being
made, if the summary line is insufficient. The blank line above is
required. This should be wrapped at 72 characters, but otherwise has
no particular length requirements.

If you need to write multiple paragraphs, feel free.

LP: #NNNNNNN (replace with the appropriate bug reference or remove
this line entirely if there is no associated bug)

Additional Context

Test Steps

Checklist:

• My code follows the process laid out in the documentation
• I have updated or added any unit tests accordingly
• I have updated or added any documentation accordingly

[nibalizer]

This is a work in progress

[OddBloke]

Thanks for this branch @nibalizer! Some comments inline.

[OddBloke]

Should this move outside the try block here? This call failing would not really be a "Failed partitioning operation", and perhaps should not be ignored in the same way.

[nibalizer]

I took a whack at this, let me know if you think this works better.

[github-actions]

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging mitechie, and he will ensure that someone takes a look soon.

(If the pull request is closed, please do feel free to reopen it if you wish to continue working on it.)

[HeroCC]

Could this be reopened? This feature would be quite useful.

[TheRealFalcon]

Github won't let us reopen this one because the base branch has changed, but we can certainly open a new PR referencing this one. @HeroCC or @nibalizer , are you interested in pushing this across the finish line? I think what we have currently looks good, but we'd need to also add/modify some unit testing before we'd be ready to merge it.

[dirien]

Yeah stumled also on this on Equinix Metal... Would be nice to get this activated again...