Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy GA readiness #31

Merged
merged 9 commits into from
Jan 21, 2023
Merged

Proxy GA readiness #31

merged 9 commits into from
Jan 21, 2023

Conversation

rbarry82
Copy link
Contributor

@rbarry82 rbarry82 commented Dec 4, 2022 •
edited
Loading

Issue

Fix dashboard ingestion with the new "topology" in some reactive dashboards.

In addition:

  • Dynamically generate Alertmanager rules for NRPE checks
  • Add a check label for NRPE jobs
  • Make the logic around adding/removing jobs/relations much more flexible, so changes in Prometheus relations do not "accidentally" clobber generate NRPE rules/jobs when the databag is restarted

Update the Grafana and Prometheus libs to pull in changes (the changes to both *Aggregator classes are in different PRs in those repos)

Closes #33

@rbarry82 rbarry82 merged commit 0a8c22e into main Jan 21, 2023
@rbarry82 rbarry82 deleted the proxy-release-readiness branch January 21, 2023 03:48
This was referenced Feb 16, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simskij simskij simskij left review comments

@dstathis dstathis dstathis approved these changes

@sed-i sed-i Awaiting requested review from sed-i

@Abuelodelanada Abuelodelanada Awaiting requested review from Abuelodelanada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add nrpe unit name label to the metrics exported by the nrpe exporter
3 participants
@rbarry82 @simskij @dstathis