Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: temporarily disabling non-ubuntu testing due to LXD changes #176

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

syu-w
Copy link
Contributor

@syu-w syu-w commented Jan 23, 2024

No description provided.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a2ab6c4) 99.20% compared to head (b42f740) 99.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          26       26           
  Lines        1130     1130           
  Branches      194      194           
=======================================
  Hits         1121     1121           
  Misses          6        6           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syu-w syu-w requested review from lengau and mr-cal January 23, 2024 17:10
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you create an issue and link to this PR so we don't forget to start testing again once we have an alternative location to source these images?

(the alternative would be to add the xfail decorator and add a comment in the code itself to why they are disabled)

@syu-w
Copy link
Contributor Author

syu-w commented Jan 23, 2024

Will you create an issue and link to this PR so we don't forget to start testing again once we have an alternative location to source these images?

(the alternative would be to add the xfail decorator and add a comment in the code itself to why they are disabled)

Added

Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer the idea of an xfail in addition to the issue, but since this is something we're going to be fixing pretty quickly I'd rather just get this pushed :-)

@lengau lengau merged commit daf3d90 into main Jan 24, 2024
7 checks passed
@lengau lengau deleted the disable-non-ubuntu-tests branch January 24, 2024 18:48
lengau pushed a commit that referenced this pull request Jul 16, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants