patch(_get_workflow_version.yaml): Use commit SHA instead of ref #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the ref (i.e. PR branch) is updated before _get_workflow_version.yaml is run, it will use the wrong commit to determine the workflow version in the calling workflow
carlcsaposs-canonical
requested review from
taurus-forever,
dragomirp and
shayancanonical
dragomirp
approved these changes
Nov 29, 2023
|
tested on canonical/postgresql-operator#296 |
taurus-forever
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ref (i.e. PR branch) is updated before _get_workflow_version.yaml is run, it will use the wrong commit to determine the workflow version in the calling workflow