patch(integration_test_charm.yaml): Free up disk space #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
force-pushed
the
free-disk-space
branch
3 times, most recently
from
613adba
to
6aaafa6
Compare
|
depends on #105 |
dragomirp
approved these changes
Nov 29, 2023
taurus-forever
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
LGTM, but:
-
Are we cleaning the same pathes for Canonical runners GH runners? It looks strange, but code is correct. LGTM.
-
we will have surprises if AGENT_TOOLSDIRECTORY=/
Better safe then sorry (c) MrMEEE/bumblebee-Old-and-abbandoned#123.
IMHO, at least:
: "${AGENT_TOOLSDIRECTORY?ERROR: variable 'AGENT_TOOLSDIRECTORY' is NOT defined, aborted.}"
...
rm -rf "${AGENT_TOOLSDIRECTORY:?}"
Reduce issues with running out of disk space (causing the runner to crash)
carlcsaposs-canonical
force-pushed
the
free-disk-space
branch
from
6aaafa6
to
98a1d45
Compare
taurus-forever
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce issues with running out of disk space (causing the runner to crash)