Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ldap lib #54

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Fix ldap lib #54

merged 6 commits into from
Aug 13, 2024

Conversation

nsklikas
Copy link
Contributor

@nsklikas nsklikas commented Aug 7, 2024

IAM-989

@nsklikas nsklikas requested a review from a team as a code owner August 7, 2024 11:57
@nsklikas nsklikas force-pushed the IAM-989 branch 2 times, most recently from bd9b68b to e9ba2f5 Compare August 7, 2024 15:24
src/integrations.py Outdated Show resolved Hide resolved
src/integrations.py Outdated Show resolved Hide resolved
BarcoMasile
BarcoMasile previously approved these changes Aug 8, 2024
Copy link
Contributor

@BarcoMasile BarcoMasile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I put a +1 on some suggestion by Shu

The client app needs the raw password, not the hash of the password
- Do not send the hashed password
- Handle cases where the event would fail, causing the password to be
  lost
@nsklikas nsklikas merged commit abb1401 into main Aug 13, 2024
3 checks passed
@nsklikas nsklikas deleted the IAM-989 branch August 13, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants