tls: Disable clientsessioncache #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ClientCessionCache causes incompatibilities between go-dqlite 1.11.6 and 1.11.7. go-dqlite 1.11.7 contains a new SimpleTLSConfig that eliminated incompatibilities with go 1.19.6 and newer. However, it seems nodes running go-dqlite versions older than 1.11.7 throw TLS errors when communication with modern nodes if the ClientCessionCache is enabled. So, disable the ClientCessionCache by default. Users can still opt to enable it by adapting the client config returned by SimpleTLSConfig. Signed-off-by: Mathieu Borderé <mathieu.bordere@canonical.com>
|
I'll wait for some user feedback and write a test in meanwhile. |
tomponline
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ClientCessionCachecauses incompatibilities between go-dqlite1.11.6and1.11.7.go-dqlite
1.11.7contains a new SimpleTLSConfig that eliminated incompatibilities with go 1.19.6 and newer. However, it seems nodes running go-dqlite versions older than1.11.7throw TLS errors when communication with modern nodes if theClientCessionCacheis enabled.So, disable the
ClientCessionCacheby default. Users can still opt to enable it by adapting the client config returned bySimpleTLSConfig.