-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(cos-agent) Use peer relation data for communicating all principals' data #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @PietroPasotti graph LR
zk/0 --->|"
metrics_alert_rules
log_alert_rules
dashboards
metrics_scrape_jobs
log_slots
"| gagent/i --->|"
metrics_alert_rules
log_alert_rules
dashboards
"| gagent/leader* --->|"
metrics_alert_rules
log_alert_rules
dashboards
"| cos
|
PietroPasotti
requested review from
Abuelodelanada,
rbarry82,
lucabello,
PietroPasotti,
dstathis and
simskij
as code owners
March 31, 2023 08:57
simskij
approved these changes
Apr 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested at 1c7d99ad10e344ae187f55f6473df5e71c2554a4
, which worked great.
sed-i
changed the title
(cos-agent) Use peer relation data for communicating all principals' data (WIP)
(cos-agent) Use peer relation data for communicating all principals' data
Apr 3, 2023
dstathis
approved these changes
Apr 4, 2023
sed-i
added a commit
that referenced
this pull request
Apr 14, 2023
* Cleanup etc. (#90) * Fix metadata and snap usage (#91) * Class split (#92) * Make static_configs into a list (#96) * add option for tls insecure skip verify (#93) * Add dashboards handler (#97) * Scenario tests and machine charm rename (#99) * spelling errors (#100) * Clear machine metadata relations (#98) * Add tests for update-status (#101) * Type fixes (#102) * small fixes and scenarios (#103) * Machine charm lib (#95) * Feature/fix prop (#111) * LINT. Fix the grafana data iteration (#112) * plug extraction (#105) * Sub relation priority (#114) * Fix a possible JSON loading exception (#119) * purged grafana dashboard requirer (#117) * Fix labels (#120) * Use cosl for Rules and JujuTopology (#121) * Fix position files (#116) * top level documentation for cos_machine lib (#122) * Add juju-info itest (#123) * Snap plug logs (#124) * Loki shared logs monitoring (#125) * Rename cos-machine to cos-agent (#129) * wrong scope for grafana-dashboards-provider relation (#134) * FIX Grafana dashboards files are stored in a bad format (#139) * move on-refresh config to unit databag (#142) * Set BlockedStatus per relation (#141) * Be looser with finding snap plug mounts (#145) * Use an actual uuid4, alerts() is now a property everywhere (#151) * Replace DS_PROMETHEUS with prometheusds (#148) * Cleanup (#152) * use better locations for the positions files (#155) * added typing for metrics endpoint dict (#149) * Fix fstab parser (#159) * (cos-agent) Use peer relation data for communicating all principals' data (#160) * add support for the grafana cloud integrator charm (#150) Co-authored-by: Dylan Stephano-Shachter <dylan.stephano-shachter@canonical.com> Co-authored-by: awnn <adrian@webyda.se> Co-authored-by: Ryan Barry <ryan.barry@canonical.com> Co-authored-by: PietroPasotti <pietro.pasotti@canonical.com> Co-authored-by: Jose C. Massón <939888+Abuelodelanada@users.noreply.github.com> Co-authored-by: sed-i <82407168+sed-i@users.noreply.github.com> Co-authored-by: Simon Aronsson <simme@arcticbit.se> Co-authored-by: Luca Bello <36242061+lucabello@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Subordinate charms only see one unit over the subordinated relation - the principal unit. I.e. subordinate units cannot iterate over relation data from other units.
Combined with a leader guard, this means only one principal unit can get its files across - the one that is related to the subordinate leader.
Solution
_fetch_data_from_relation
Fixes #158.
Context
Testing Instructions
cos-agent
lib from this PR.first-zk
(two units),second-zk
(one unit is enough) and gagent from this PR.juju show-unit ...
Eventually we'd like to test something like this:
Release Notes
Use peer relation data for communicating all principals' data.