Update the actions example, template panels enclosed in rows #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbarry82
requested review from
sed-i,
Abuelodelanada,
dstathis and
simskij
as code owners
sed-i
approved these changes
Jan 4, 2023
Co-authored-by: Leon <82407168+sed-i@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Grafana 9 also allows for setting top-level
"rows"as a key, which contains an array of objects, potentially including"panels".In the case of dashboards which contain only rows,
grafana_dashboardpreviously threw an exception, but we should cover the case also.Solution
If a
"rows"key is present, iterate through it and modify the panels contained within. Use.get()for the"panels"key to avoid aKeyError.Context
Closes #166
Closes #170
Closes #164
Release Notes
Behave appropriately when rows are found (or only rows). Update the README for Juju3 actions.