Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add proxy config from env variables #242

Merged
merged 4 commits into from
Aug 11, 2023

fix unit tests

05e38a5
Select commit
Failed to load commit list.
Sign in for the full log view
Merged

add proxy config from env variables #242

fix unit tests
05e38a5
Select commit
Failed to load commit list.
GitHub Actions / Inclusive naming check succeeded Aug 10, 2023 in 0s

reviewdog [Inclusive naming check] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (16)

tests/unit/test_charm.py|344 col 16| [warning] sanity may be insensitive, use confidence check, coherence check instead
tests/unit/test_charm.py|344 col 16| [error] sanity may be insensitive, use confidence, quick check, coherence check instead
lib/charms/grafana_k8s/v0/grafana_auth.py|32 col 5| [warning] whitelist may be insensitive, use allowlist instead
lib/charms/grafana_k8s/v0/grafana_auth.py|64 col 12| [warning] whitelist may be insensitive, use allowlist instead
lib/charms/grafana_k8s/v0/grafana_auth.py|187 col 33| [warning] whitelist may be insensitive, use allowlist instead
lib/charms/grafana_k8s/v0/grafana_auth.py|188 col 80| [warning] whitelist may be insensitive, use allowlist instead
lib/charms/grafana_k8s/v0/grafana_auth.py|543 col 8| [warning] whitelist may be insensitive, use allowlist instead
lib/charms/grafana_k8s/v0/grafana_auth.py|563 col 12| [warning] whitelist may be insensitive, use allowlist instead
lib/charms/grafana_k8s/v0/grafana_auth.py|579 col 11| [warning] whitelist may be insensitive, use allowlist instead
lib/charms/grafana_k8s/v0/grafana_auth.py|580 col 48| [warning] whitelist may be insensitive, use allowlist instead
lib/charms/grafana_k8s/v0/grafana_auth.py|580 col 62| [warning] whitelist may be insensitive, use allowlist instead
tests/unit/test_kubernetes_service.py|58 col 40| [warning] Dummy may be insensitive, use placeholder, sample instead
src/charm.py|868 col 33| [warning] sanity may be insensitive, use confidence check, coherence check instead
src/charm.py|868 col 33| [error] sanity may be insensitive, use confidence, quick check, coherence check instead
tests/integration/test_grafana_auth.py|5 col 27| [warning] dummy may be insensitive, use placeholder, sample instead
tests/integration/grafana-tester/metadata.yaml|5 col 36| [warning] dummy may be insensitive, use placeholder, sample instead

View more details on GitHub Actions