implement certificate transfer interface #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsklikas
reviewed
Nov 30, 2023
shipperizer
reviewed
Nov 30, 2023
observability-noctua-bot
changed the title
bencekov
requested review from
sed-i,
Abuelodelanada,
lucabello,
PietroPasotti,
dstathis and
simskij
as code owners
sed-i
reviewed
Dec 4, 2023
sed-i
approved these changes
Dec 4, 2023
bencekov
added a commit
to bencekov/grafana-k8s-operator
that referenced
this pull request
Dec 4, 2023
refactor: based on comments
fix: pinned pytest-asyncio to version 0.21.1
bencekov
force-pushed
the
IAM-591-Implement-certificate-transfer-interface
branch
from
5be044b
to
00b505f
Compare
|
To avoid the issues with asyncio that came from the recent breaking changes I pinned pytest-asyncio to version 0.21.1. |
sed-i
reviewed
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR is a solution for issue #277.
Solution
This pr implements handling the self-signed-certificate's certificate_transfer interface.
When the certificate_transfer integration databag is updated with a new certificate the following steps are taken:
When the cert is revoked by the relation, the file in /usr/local/share/ca-certificates is deleted, grafana is restarted,
and the trusted certificates are updated.
Context
Testing Instructions
An integration test is included to check for the received certificate being included among the trusted certificates.
tox -e integrationRelease Notes