-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump charm revisions #273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I have a couple of questionts:
- Shouldn't this include tests for the Kratos IdP?
- Also should we try updating traefik?
1821808
to
b4e144a
Compare
I'll work on this as part of https://warthogs.atlassian.net/browse/IAM-996
Updated, thanks |
54c8299
to
7fbb0d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if my comment makes sense, but if we want other people to use this, we need to come up with a solution that has a stable API.
If you disagree, feel free to disregard it and maybe we can come up with a solution for this in another PR
If I deploy the bundle via:
And the try to login (via the hydra cli client), I will get redirected to the login page: And if then click But if I try to input some random email, I will get an Is this expected, is it a bug we should open in the login UI or is something wrong with the kratos config? AFAICT the error comes from this line |
It is not expected, this can be reproduced if webauthn is disabled, otherwise it displays the correct message. Perhaps we should not show the "Sign in with security key" button at all in that scenario. |
b5d3710
to
826b979
Compare
thought about it, we could remove the traefik update and have the oauth tools changes in a separate pr
826b979
to
4843838
Compare
As discussed with @nsklikas, I reverted the traefik revision bump to address |
This PR:
fixes #268