Address the empty tarball issue #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cole Miller <cole.miller@canonical.com>
|
Confirmed that a proper tarball is uploaded with the failure artifact for the failed CI jobs for this PR 🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #105. The basic issue is that the
tarprocess was getting SIGPERM while trying to read the data directory -- this is fixed by invoking with sudo. The failure was masked by a use ofstrinstead ofinfoor another function that prints to the log.With this change, I sometimes see tar complaining about the data directory changing during archival, because the app process is still running while Jepsen runs
log-files. I'm not sure how to deal with that, because we don't control the order of events during shutdown, but I think it can be left to a follow-up PR in any case.Signed-off-by: Cole Miller cole.miller@canonical.com