Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/mod cache action #1310

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

SimoneDutto
Copy link
Contributor

Description

Fix:

  • trigger the cache action only on specific branch (v3, feature*). This is to avoid triggering the cache action in our private fork too many times
  • go build command requires some files to succeed

The nuance with github actions cache is:

  • every branch inherits the default branch cache
  • the pr inherits the base branch cache

Fixes JIRA/GitHub issue number

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

Notes for code reviewers

@SimoneDutto SimoneDutto requested a review from a team as a code owner August 8, 2024 14:57
@@ -18,5 +22,11 @@ jobs:
with:
go-version-file: 'go.mod'

- name: Add volume files
run: |
touch ./local/vault/approle.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be pendantic, I believe we no longer need the other files (at least not roleid.txt) that was refactored to no longer be needed some time ago and wasn't removed from creation in the CI job.

@SimoneDutto SimoneDutto merged commit 8706de4 into canonical:v3 Aug 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants