feat: added update-status handler #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#188 Summary of changes: - Updated tox.ini to run test properly.
Summary of changes: - Updated libraries.
#188 Summary of changes: - Modified charm code to use sidecar pattern as per approved specification. - Added required manigests. - Modified existing tests to work with new charm. - Modified test bundle definitions and helpers. - Added requirements.* NOTE: Additional integration and unit tests, upgrade and update status handlers, aggregation rules will be added in another PRs.
…om:canonical/kfp-operators into kf-1668-gh188-feat-kfp-api-sidecar-rewrite
…8-gh188-feat-kfp-api-sidecar-rewrite
Summary of changes: - Added service patch lib needed by charm.
Co-authored-by: Maksim Beliaev <beliaev.m.s@gmail.com>
Co-authored-by: Maksim Beliaev <beliaev.m.s@gmail.com>
Co-authored-by: Maksim Beliaev <beliaev.m.s@gmail.com>
Summary of changes: - Added missing lib files. - Updated code according to code review comments.
Summary of changes: - Removed not needed exception handling.
Summary of changes: - Modified error handling and added log message for failed configuration generation. - Removed note needed default. - Modified unit tests accordingly.
Summary of changes: - Added mock to unit test.
Summary of changes: - Modified code to use pathlib.
Summary of changes: - Integration tests were failing due to missing 'series'. Added 'series=kubernetes'
Summary of changes: - Pinned Juju version in workflow. See integrate.yaml for more details.
Summary of changes: - Remvoed pinning to 2.9.34. - Added model-config to set default series to focal.
Co-authored-by: Maksim Beliaev <beliaev.m.s@gmail.com>
Co-authored-by: Maksim Beliaev <beliaev.m.s@gmail.com>
Co-authored-by: Maksim Beliaev <beliaev.m.s@gmail.com>
Co-authored-by: Maksim Beliaev <beliaev.m.s@gmail.com>
Co-authored-by: Maksim Beliaev <beliaev.m.s@gmail.com>
Co-authored-by: Maksim Beliaev <beliaev.m.s@gmail.com>
ca-scribner
reviewed
Apr 17, 2023
ca-scribner
previously requested changes
Apr 17, 2023
Summary of changes: - Removed leader check from update status handler. It is done in check status function. - Added proper handlign of error and logging.
Co-authored-by: Maksim Beliaev <beliaev.m.s@gmail.com>
Co-authored-by: Maksim Beliaev <beliaev.m.s@gmail.com>
i-chvets
dismissed stale reviews from ca-scribner and beliaev-maksim
Addressed comments.
beliaev-maksim
previously approved these changes
Apr 17, 2023
i-chvets
dismissed stale reviews from beliaev-maksim and ca-scribner
via
f01a91a
ca-scribner
previously approved these changes
Apr 17, 2023
Summary of changes: - Updated checks settings. - Modified integration tests to wait for all applications explicitly.
…om:canonical/kfp-operators into kf-1668-gh188-feat-kfp-api-status-update
Summary of changes: - Increased timeout and threshold.
beliaev-maksim
approved these changes
Apr 18, 2023
DnPlas
added a commit
that referenced
this pull request
Jul 31, 2023
The kfp-api individual tests were failing due to a number of reasons, mainly caused by how this charm's dependencies are deployed and the time it takes for those to be up and ready. This commit ensures those dependencies (mysql, minio, prometheus) are active and idle within a reasonable time to avoid timeouts and charms misconfigurations. 1. For mysql-k8s, the charm is now deployed from channel 8.0/edge, a version that contains the testing profile option, which constraints the charm in a recommended way to deploy on GitHub runners. 2. For prometheus-k8s, since this charms requires a significant amount of time to deploy, the wait for idle timeout is increased to 90*20. This change was introduced by #178, but incorrectly reverted by #197. Part of #243
DnPlas
added a commit
that referenced
this pull request
Jul 31, 2023
…on tests (#273) * ci: increase GitHub runners storage space for individual integration tests Increasing the storage space will prevent individual charms to fail by ensuring charms can be deployed in an environment with enough storage space. * tests: fix kfp-api integration tests in multiple places The kfp-api individual tests were failing due to a number of reasons, mainly caused by how this charm's dependencies are deployed and the time it takes for those to be up and ready. This commit ensures those dependencies (mysql, minio, prometheus) are active and idle within a reasonable time to avoid timeouts and charms misconfigurations. 1. For mysql-k8s, the charm is now deployed from channel 8.0/edge, a version that contains the testing profile option, which constraints the charm in a recommended way to deploy on GitHub runners. 2. For prometheus-k8s, since this charms requires a significant amount of time to deploy, the wait for idle timeout is increased to 90*20. This change was introduced by #178, but incorrectly reverted by #197. Fixes: #243
DnPlas
added a commit
that referenced
this pull request
Aug 4, 2023
…on tests (#273) * ci: increase GitHub runners storage space for individual integration tests Increasing the storage space will prevent individual charms to fail by ensuring charms can be deployed in an environment with enough storage space. * tests: fix kfp-api integration tests in multiple places The kfp-api individual tests were failing due to a number of reasons, mainly caused by how this charm's dependencies are deployed and the time it takes for those to be up and ready. This commit ensures those dependencies (mysql, minio, prometheus) are active and idle within a reasonable time to avoid timeouts and charms misconfigurations. 1. For mysql-k8s, the charm is now deployed from channel 8.0/edge, a version that contains the testing profile option, which constraints the charm in a recommended way to deploy on GitHub runners. 2. For prometheus-k8s, since this charms requires a significant amount of time to deploy, the wait for idle timeout is increased to 90*20. This change was introduced by #178, but incorrectly reverted by #197. Fixes: #243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#188
Summary of changes: