Fix unversioned package update regression #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to #160, we were passing filenames to pip for the wheelhouse install rather than package names. It seems that using filenames implicitly disables pip's caching of package archive files. After #160, since we are now using package names rather than file names (which does allow pip to handle dependency resolution better), the packages were getting copied out of the wheelhouse directory and into pip's cache dir on the initial install and not updated unless the filename changed (i.e., the version number changed). Some of the OpenStack charms use a shared library directly from GitHub which doesn't bother tracking the library version, causing it to always have the same version. Adding `--no-cache-dir` forces pip to always use the copy from the wheelhouse, even if it seems like it hasn't been changed, based on the file name. This also switches from `--ignore-installed` to `--force-reinstall` because the latter is cleaner since the former can leave artifacts from previous package versions in the venv if they are removed from the newer pacakge version. Fixes #166
thedac
approved these changes
Apr 28, 2020
johnsca
added a commit
that referenced
this pull request
May 12, 2020
The change in #167 to use --force-reinstall, while significantly safer overall does fail on bionic and earlier when using `use_venv: false`. This was missed in the existing functional tests, so this adds tests to cover that.
Cynerva
pushed a commit
to charmed-kubernetes/layer-basic
that referenced
this pull request
Jun 1, 2020
…install Fix unversioned package update regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #160, we were passing filenames to pip for the wheelhouse install rather than package names. It seems that using filenames implicitly disables pip's caching of package archive files. After #160, since we are now using package names rather than file names (which does allow pip to handle dependency resolution better), the packages were getting copied out of the wheelhouse directory and into pip's cache dir on the initial install and not updated unless the filename changed (i.e., the version number changed). Some of the OpenStack charms use a shared library directly from GitHub which doesn't bother tracking the library version, causing it to always have the same version.
Adding
--no-cache-dirforces pip to always use the copy from the wheelhouse, even if it seems like it hasn't been changed, based on the file name.This also switches from
--ignore-installedto--force-reinstallbecause the latter is cleaner since the former can leave artifacts from previous package versions in the venv if they are removed from the newer package version.Fixes #166