Fix reinstall error with use_venv: false on bionic and earlier. #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in #167 to use --force-reinstall, while significantly safer overall does fail on bionic and earlier when using `use_venv: false`. This was missed in the existing functional tests, so this adds tests to cover that.
johnsca
added a commit
to charmed-kubernetes/layer-basic
that referenced
this pull request
Aug 4, 2020
adam-stokes
pushed a commit
to charmed-kubernetes/layer-basic
that referenced
this pull request
Aug 4, 2020
* Remove allow_hosts workaround for Focal and after (canonical#169) * Fix regression for offline deployments (canonical#172) Add back the writing of ``/root/.pydistutils.cfg`` for all series and drop the now removed ``allow_hosts`` keyword for Eoan and onwards. The ``find_links`` keyword with path to wheelhouse still needs to be there for successful offline install of some Python packages. Fixes canonical#171 * Pin netaddr (canonical#179) netaddr 0.7.20 pulls in importlib-resources, which depends on a newer version of setuptools_scm than we use. It also pulls zipp, which depends on a newer version of setuptools than we use. Pinning to 0.7.19 avoids this. * Stop pip3 AND easy_install from accessing network on install (canonical#184) * Stop pip3 AND easy_install from accessing network on install This change prevents the wheelhouse installation from accessing the network at all. This allows it to install quickly behind firewalls that silently drop packets causing long delays in installing the packages if a dependency is 'later' in the wheelhouse install, which is done in directory order (usually alphabetically). Closes launchpad bug: #1884449 * Add required snap install core line * Remove Eoan from functional tests (canonical#186) Eoan has been EOLed and no longer has images available, so it gets stuck in pending and causes the functional tests to hang. * Fix lint failures (from canonical#170) * Use ``travis_wait`` to keep func test alive (canonical#162) At present we have enabled excessive debug-logging to accompilsh the same thing, but that makes it unpleasant to look at. Change permissions on the LXD socket to give travis user access instead of using the sudo back to ourself trick as it leads to some unwanted complexity. Add Python 3.8 target to test matrix. Replace ``cryptography`` with ``psycopg2`` as it has not banned Python 3.4 support. Closes canonical#161 Co-authored-by: Frode Nordahl <frode.nordahl@canonical.com> Co-authored-by: Paul Goins <paul.goins@canonical.com> Co-authored-by: Alex Kavanagh <567675+ajkavanagh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #167 to use
--force-reinstall, while significantly safer overall does fail on bionic and earlier when usinguse_venv: false. This was missed in the existing functional tests, so this first adds tests to cover that and ensure that things like this will be caught going forward, then adds a fix to use--force-reinstallwhen possible but otherwise fall back to the previous--ignore-installedbehavior.Fixes #168