Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a generic wayland system compositor support #132

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mariogrip
Copy link

This adds a generic wayland system compositor impl based on the old unity-system-compositor. This allows lightdm to handle a generic nested wayland compositor setup.

This does not implement xwayland to allow to run x sessions on top of a wayland system compositor.

This is set as draft to get some input if this is something upstream wants, i'll impement tests and docs if this is something upstream want.

I guess you guys didn't see this one coming back :)

@robert-ancell
Copy link
Collaborator

It's back... :)

@robert-ancell
Copy link
Collaborator

@mariogrip are you still working on this / planning on using it?

@mariogrip
Copy link
Author

@robert-ancell Yes, would this be ok as is?

@mariogrip mariogrip marked this pull request as ready for review February 15, 2023 12:18
This adds a generic wayland system compositor impl based on the old
unity-system-compositor. This allows lightdm to handle a generic nested
wayland compositor setup.

This does not implement xwayland to allow to run x sessions on top of a
wayland system compositor.
We always read raw data from the pipe, thus this should have been set
since this file was written. However, for some reason this has nerver
been set, and for some unknown reason this has never been a problem on
Xenial port of UT. However, not having this caused an infinite hang on
g_io_channel_read_chars(), presumebly because it's trying to interpret
a binary data as an incomplete UTF-8 character.

From:
https://gitlab.com/ubports/core/packaging/lightdm/-/commit/6616c8a8b6451751d130696f8edcf8aff0c11c35
Author: Ratchanan Srirattanamet
@github-actions
Copy link

Hey! mariogrip has not signed the Canonical CLA which is required to get this contribution merged on this project.

Please head over to https://ubuntu.com/legal/contributors to read more about it.

@mariogrip
Copy link
Author

I have signed it now

@mariogrip
Copy link
Author

@robert-ancell

@robert-ancell
Copy link
Collaborator

Sorry for the delay on this. I'm hesitant in landing this as I'm not sure if this feature will be widely used. Hopefully it should be relatively easy to maintain it as a branch for your use case and we can reconsider in the future? If you are a project that would make use of this please comment in this issue so we can see the demand.

@seocamo
Copy link

seocamo commented Apr 30, 2023

would this enable lightdm to start Sway or Hyprland?, if so then this is really important as many of the WM users that i meet love LightDM, but is moving to SDDM because of Hyprland.
i would love to go back to lightdm too.

@an4s911
Copy link

an4s911 commented Oct 2, 2024

I really hope that this will be added to lightdm in order to support sway or hyprland. I was just trying out hyprland and realized that lightdm doesn't support it. And I really wish if it was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants