Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning cert none charm logging #425

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

PietroPasotti
Copy link
Contributor

we shouldn't warn as it's possibly a happy path

@PietroPasotti PietroPasotti requested a review from a team as a code owner June 19, 2024 09:36
lib/charms/loki_k8s/v0/charm_logging.py Dismissed Show dismissed Hide dismissed
@PietroPasotti PietroPasotti merged commit 86fc551 into main Jul 29, 2024
13 checks passed
@PietroPasotti PietroPasotti deleted the fix-warning-cert-none-charm_logging branch July 29, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants