Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OIDC cookie name #569

Closed
markylaing opened this issue Dec 6, 2023 · 1 comment · Fixed by #658
Closed

Update OIDC cookie name #569

markylaing opened this issue Dec 6, 2023 · 1 comment · Fixed by #658

Comments

@markylaing
Copy link

When canonical/lxd#12628 is merged. The name of the oidc_access cookie will change to oidc_identity. It should be a simple search and replace :)

I can see that this is referenced in two places: https://github.com/search?q=repo%3Acanonical%2Flxd-ui%20oidc_access&type=code
@stgraber
Copy link

stgraber commented Dec 9, 2023

Probably want to support both names to avoid breaking current users.

edlerd added a commit to edlerd/lxd-ui that referenced this issue Feb 20, 2024
@edlerd
fix(oidc) update cookie name after upstream change canonical#569
a8f2427
@edlerd edlerd mentioned this issue Feb 20, 2024
Merged
edlerd added a commit to edlerd/lxd-ui that referenced this issue Feb 20, 2024
@edlerd
fix(oidc) update cookie name after upstream change canonical#569
92e7e7e 
Signed-off-by: David Edler <david.edler@canonical.com>
edlerd added a commit to edlerd/lxd-ui that referenced this issue Feb 20, 2024
@edlerd
fix(oidc) update cookie name after upstream change canonical#569
47f9ca7 
Signed-off-by: David Edler <david.edler@canonical.com>
edlerd added a commit to edlerd/lxd-ui that referenced this issue Feb 21, 2024
@edlerd
fix(oidc) rely on api response for auth checks, as the oidc cookie is…
caf75c8 
… now httponly and not visible to the ui, hide status bar and avoid operation fetch in case a user is not authenticated, fixes canonical#569

Signed-off-by: David Edler <david.edler@canonical.com>
edlerd added a commit to edlerd/lxd-ui that referenced this issue Feb 21, 2024
@edlerd
fix(oidc) rely on api response for auth checks, as the oidc cookie is…
b037aad 
… now httponly and not visible to the ui, hide status bar and avoid operation fetch in case a user is not authenticated, fixes canonical#569

Signed-off-by: David Edler <david.edler@canonical.com>
edlerd added a commit to edlerd/lxd-ui that referenced this issue Feb 21, 2024
@edlerd
fix(oidc) rely on api response for auth checks, as the oidc cookie is…
83df6d8 
… now httponly and not visible to the ui, hide status bar and avoid operation fetch in case a user is not authenticated, fixes canonical#569

Signed-off-by: David Edler <david.edler@canonical.com>
edlerd added a commit that referenced this issue Feb 21, 2024
@edlerd
fix(oidc) rely on api response for auth checks, as the oidc cookie is…
621f2e1 
… now httponly and not visible to the ui, hide status bar and avoid operation fetch in case a user is not authenticated, fixes #569

Signed-off-by: David Edler <david.edler@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update cookie name after upstream change #569 edlerd/lxd-ui
2 participants
@stgraber @markylaing