Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow certificate adding with tokens WD-4251 #343 #374

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Allow certificate adding with tokens WD-4251 #343 #374

merged 1 commit into from
Jun 7, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Jun 7, 2023

Done

  • added alternative to add existing certificate with token

Fixes WD-4251 #343

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described in the Readme.
  2. Perform the following QA steps:
    • test adding a certificate already in the browser with token

@webteam-app
Copy link

Demo starting at https://lxd-ui-374.demos.haus

@edlerd edlerd requested a review from lorumic June 7, 2023 14:00
lorumic
lorumic reviewed Jun 7, 2023
View reviewed changes
src/pages/certificates/CertificateMain.tsx Outdated Show resolved Hide resolved
src/pages/certificates/CertificateMain.tsx Outdated Show resolved Hide resolved
src/pages/certificates/CertificateAdd.tsx Outdated Show resolved Hide resolved
src/api/certificates.tsx Outdated Show resolved Hide resolved
src/pages/certificates/CertificateAddForm.tsx Outdated Show resolved Hide resolved
@edlerd edlerd requested a review from lorumic June 7, 2023 17:17
lorumic
lorumic approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying all the changes!

@edlerd edlerd merged commit d930130 into canonical:main Jun 7, 2023
@edlerd edlerd deleted the certificate-add-tokens branch June 7, 2023 18:54
@edlerd edlerd mentioned this pull request Jun 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorumic lorumic lorumic approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edlerd @webteam-app @lorumic