Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local docs for images page #538

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Nov 15, 2023

Done

  • Added the local docs logic to the Images page

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Navigate to the Images page
    • Check that, if LXD version is above 5.18, a local docs link is present for the info icon in the header instead of the remote one

@webteam-app
Copy link

Demo starting at https://lxd-ui-538.demos.haus

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, this was missed with the subsequent PRs.

@lorumic lorumic merged commit 62a8dd3 into canonical:main Nov 15, 2023
5 checks passed
@lorumic lorumic deleted the images-local-docs branch November 15, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants