Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: speed up e2e tests [WD-8560] #641

Merged
merged 1 commit into from
Feb 12, 2024
Merged

chore: speed up e2e tests [WD-8560] #641

merged 1 commit into from
Feb 12, 2024

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Feb 9, 2024 •
edited
Loading

Done

  • Adjusted test suites to reuse lxd resources across tests instead of creating new ones for every test.
  • Use matrix strategy to run browser specific e2e tests. This splits up the test workload across two runners and essentially should halve the test run time.

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Ensure ci passes and test speed improves

@webteam-app
Copy link

Demo starting at https://lxd-ui-641.demos.haus

@mas-who mas-who changed the title chore: speed up e2e tests chore: speed up e2e tests [WD-8560] Feb 9, 2024
@mas-who mas-who force-pushed the speedup-tests branch 9 times, most recently from 43c30c6 to b3d8f05 Compare February 9, 2024 11:38
lorumic
lorumic reviewed Feb 12, 2024
View reviewed changes
.github/workflows/pr.yaml Show resolved Hide resolved
tests/instances.spec.ts Outdated Show resolved Hide resolved
tests/instances.spec.ts Outdated Show resolved Hide resolved
tests/networks.spec.ts Show resolved Hide resolved
tests/notification.spec.ts Show resolved Hide resolved
tests/profiles.spec.ts Show resolved Hide resolved
tests/storage.spec.ts Show resolved Hide resolved
@mas-who mas-who force-pushed the speedup-tests branch 2 times, most recently from 6a448be to d8b1ccf Compare February 12, 2024 11:03
@mas-who mas-who requested a review from lorumic February 12, 2024 14:03
lorumic
lorumic approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the changes, one minor comment about one change that could also be reverted.

src/context/toastNotificationProvider.tsx Outdated
@@ -19,7 +19,7 @@ import React, {
useState,
} from "react";

const HIDE_NOTIFICATION_DELAY = 5_000;
export const HIDE_NOTIFICATION_DELAY = 5_000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be reverted as well at this point.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aah yes, will revert that 👍

@mas-who
chore: speed up e2e tests
0870355 
Signed-off-by: Mason Hu <mason.hu@canonical.com>
@mas-who mas-who merged commit c663825 into canonical:main Feb 12, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 12, 2024
workflow: remove all reports for PR #641
5f50e36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorumic lorumic lorumic approved these changes

Assignees
No one assigned
Labels
Review: Code +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mas-who @webteam-app @lorumic