Simplify loading state and avoid races on start/stopping of instances #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://lxd-ui-645.demos.haus |
edlerd
force-pushed
the
fix-loading-states
branch
from
2f490da
to
a231995
Compare
mas-who
reviewed
Feb 13, 2024
src/context/instanceLoading.tsx
Outdated
| const [instanceStates, setInstanceStates] = useState( | ||
| new Map<string, LoadingTypes>(), | ||
| ); | ||
| const instanceStates = new Map<string, LoadingTypes>(); |
There was a problem hiding this comment.
Does context trigger re-renders if we remove state here? i.e. does changes in the Map object trigger re-renders in children components subscribed to this context?
There was a problem hiding this comment.
Good point, this wasn't working properly when going to detail page / list page and back while a state change is in progress. Switched to a different approach just now.
There was a problem hiding this comment.
aah nice, by using the callback for setState calls you are guaranteed to use the correct previous state, nice! 👍
edlerd
force-pushed
the
fix-loading-states
branch
from
a231995
to
b871fa8
Compare
Signed-off-by: David Edler <david.edler@canonical.com>
edlerd
force-pushed
the
fix-loading-states
branch
from
b871fa8
to
e0bf928
Compare
mas-who
approved these changes
Feb 13, 2024
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA