Prevent custom storage volumes of type block to be used more than once #12463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
monstermunchkin
force-pushed
the
issues/12254-block-storage-volumes
branch
from
b93770f
to
f681555
Compare
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
The `Update` function returns `map[string]Device` values despite there being a `Devices` type which is the same thing. This commit changes the return types to be `Devices` instead. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
This adds a new function `AllowedInstanceDevices`. It ensures that custom block volumes are attached to a single instance only if `security.shared` is set to `false` on the custom volume. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
This commit adds checks for ensuring custom block volumes are attached to a single instance at once unless `security.shared` is set to `true` on the block volume. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
This adds a check for ensuring that custom block volumes are attached to a single instance at once unless `security.shared` is set to `true` on the storage volume. Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
monstermunchkin
force-pushed
the
issues/12254-block-storage-volumes
branch
from
f681555
to
9a950d4
Compare
|
@MusicDin want to take this one over? |
|
Sorry, I've somehow missed the notification for this one. Will finish it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12254