Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lxd group creation to installation process #13382

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

hamistao
Copy link
Contributor

@ru-fu added lxd group creation information as discussed.

@github-actions github-actions bot added the Documentation Documentation needs updating label Apr 24, 2024
Copy link

Heads up @ru-fu - the "Documentation" label was applied to this issue.

Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!
Some small suggestions.

doc/installing.md Show resolved Hide resolved
doc/installing.md Outdated Show resolved Hide resolved
doc/installing.md Outdated Show resolved Hide resolved
doc/installing.md Outdated Show resolved Hide resolved
doc/installing.md Outdated Show resolved Hide resolved
ru-fu
ru-fu previously approved these changes Apr 25, 2024
Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

doc/installing.md Outdated Show resolved Hide resolved
doc/installing.md Outdated Show resolved Hide resolved
doc/installing.md Outdated Show resolved Hide resolved
doc/installing.md Outdated Show resolved Hide resolved
doc/installing.md Outdated Show resolved Hide resolved
@tomponline
Copy link
Member

@hamistao are you able to make the changes suggested by @simondeziel ?

@tomponline
Copy link
Member

@ru-fu should we also include the group instructions in https://documentation.ubuntu.com/lxd/en/latest/tutorial/first_steps/ as we've had a new user follow this who was presumably not on Ubuntu and so got a bit stuck, see https://discourse.ubuntu.com/t/lxd-5-21-1-lts-has-been-released/43823/79

@ru-fu
Copy link
Contributor

ru-fu commented Apr 29, 2024

@ru-fu should we also include the group instructions in https://documentation.ubuntu.com/lxd/en/latest/tutorial/first_steps/ as

Yes, that makes sense! Should be a new 3rd step in the install section - can you add that @hamistao ?

we've had a new user follow this who was presumably not on Ubuntu and so got a bit stuck, see https://discourse.ubuntu.com/t/lxd-5-21-1-lts-has-been-released/43823/79

Unrelated comment - for lxd init, we're saying this can be run without sudo for simple configurations:
https://documentation.ubuntu.com/lxd/en/latest/howto/initialize/
Has that changed?

@tomponline
Copy link
Member

Unrelated comment - for lxd init, we're saying this can be run without sudo for simple configurations:
https://documentation.ubuntu.com/lxd/en/latest/howto/initialize/
Has that changed?

Its probably still fine as long as user is in lxd group.

@hamistao
Copy link
Contributor Author

@ru-fu Yes, of course! I will be pushing the chages soon.

Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
@hamistao
Copy link
Contributor Author

hamistao commented Apr 29, 2024

@ru-fu @simondeziel @tomponline I have made all requested changes. In the first steps section I only added a command to add the current user to the lxd group since the group itself is created during snap installation (step 2 in the stallation process).

Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tomponline tomponline merged commit eef2152 into canonical:main Apr 29, 2024
28 checks passed
Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@hamistao hamistao deleted the doc_add_lxd_group_creation branch June 6, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants