Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device: Allow specific USB ports to be passed through to instances (from Incus) #13419

Merged
merged 7 commits into from
May 2, 2024

Conversation

tomponline
Copy link
Member

@tomponline tomponline commented May 2, 2024

Adds serial, busnum and devnum as selector config keys for device type usb.

Feature has been added, to make it possible to distinguish between devices with identical vendorid and productid.

Fixes #13411

MHaukelid and others added 5 commits May 2, 2024 09:57
Signed-off-by: Marcus Haukelid Larsen <mhl@haukelid.dk>
(cherry picked from commit 635747f72cb1586f55ba8dc16b8a3774af882a05)
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
License: Apache-2.0
Signed-off-by: Marcus Haukelid Larsen <mhl@haukelid.dk>
(cherry picked from commit 060dfcab8e9d73905f0e48d313f331d485988de4)
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
License: Apache-2.0
Signed-off-by: Marcus Haukelid Larsen <mhl@haukelid.dk>
(cherry picked from commit e6bb09e99aedcba1c446b237bae135b568fe9ac7)
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
License: Apache-2.0
Docs part incorporated from bb60571ad33cf2c6711f61350b5c4c6f5f62b2e9

Signed-off-by: Marcus Haukelid Larsen <mhl@haukelid.dk>
(cherry picked from commit 7625b285f176c604e76453b8a9d23f4ac058116e)
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
License: Apache-2.0
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline self-assigned this May 2, 2024
@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels May 2, 2024
@tomponline tomponline requested a review from mihalicyn May 2, 2024 09:00
@tomponline
Copy link
Member Author

@jeff-hillman this should solve the problem you're having.

mihalicyn
mihalicyn previously approved these changes May 2, 2024
Copy link
Member

@mihalicyn mihalicyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

github-actions bot commented May 2, 2024

Heads up @ru-fu - the "Documentation" label was applied to this issue.

… analysis check

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline requested a review from mihalicyn May 2, 2024 09:53
@tomponline tomponline merged commit 539815d into canonical:main May 2, 2024
28 checks passed
@tomponline tomponline deleted the tp-vm-usb branch May 2, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specific USB ports to be passed through to VMs
3 participants