Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finer grain builds #13461

Merged
merged 11 commits into from
May 10, 2024
Merged

Finer grain builds #13461

merged 11 commits into from
May 10, 2024

Conversation

simondeziel
Copy link
Member

Stop building lxd-agent and lxd-migrate in the default make target.

@simondeziel
Makefile: stop building lxd-migrate and lxd-agent in build target
8e0daba 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
Makefile: add lxd-metadata target
1c80b38 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
Makefile: stop building lxd-metadata in build target
dcc86b2 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
Makefile: add lxd-metadata as a dependency for build target
af009d7 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
Makefile: rename build target to lxd and add build as alias
e256812 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
Makefile: add all target to build the client, lxd, lxd-agent and lxd-…
6b23b91 
…migrate

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
github: drop invalid ref to matrix.go in snap edge build step
4ead228 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
github: specify which make target to use when building LXD
408202d 
This is not strictly required as the default make target is still building LXD
but it's better to be explicit about our intentions.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
Makefile: add lxd-benchmark target
3beca30 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
Makefile: add lxd-benchmark to all target
d8cb6e7 
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel marked this pull request as ready for review May 8, 2024 23:17
tomponline
tomponline reviewed May 9, 2024
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does a simple call to "make" still build everything?

@simondeziel
Copy link
Member Author

simondeziel commented May 9, 2024 •
edited
Loading

Does a simple call to "make" still build everything?

No, with this PR is no longer builds lxd-agent and lxd-migrate, so it just builds lxd. I added make all to build all binaries.

Would you prefer a bare make to be equivalent to make all?

@tomponline
Copy link
Member

Would you prefer a bare make to be equivalent to make all?

Yes please.

I dont mind having more specific build targets we can use to make the CI stages more efficient, but a simple make called by a developer should build everything if needed.

https://documentation.ubuntu.com/lxd/en/latest/installing/#start-the-build

@simondeziel
Makefile: default to building all binaries: lxc, lxd, lxd-agent, lxd-…
fbbb26e 
…benchmark and lxd-migrate

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
Copy link
Member Author

but a simple make called by a developer should build everything if needed.

That's now the case as it will build: lxc, lxd, lxd-agent, lxd-benchmark and lxd-migrate (and lxd-metadata).
Before it would only build: lxd, lxd-agent and lxd-migrate (and lxd-metadata).

@tomponline tomponline merged commit 93d1d05 into canonical:main May 10, 2024
29 checks passed
@simondeziel simondeziel deleted the finer-grain-builds branch May 10, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simondeziel @tomponline