VM: Correct QEMU device ID max length #13672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hamistao <pedro.ribeiro@canonical.com>
hamistao
force-pushed
the
correct_device_id_max_lenght
branch
from
61baf1b
to
86cad43
Compare
|
@hamistao to be comfortable with this change please can you double check that the /dev/disk/by-id names do not change for block disk device passthroughs. Cheers |
|
I beleive this is safe to merge. Both entries for the device on |
Ok cool ill wait for the lxd-ci disk by id tests to be merged and passed, then merge this to check for regressions |
tomponline
changed the title
tomponline
changed the title
tomponline
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is currently causing any bugs, but the correct limit for QEMU IDs is 63, not 64. If longer than that, QEMU truncates the ID internally.