Fix SNAPSHOT_RESTORE=0 tests #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masnax
requested review from
tomponline,
roosterfish and
markylaing
as code owners
simondeziel
reviewed
May 2, 2024
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Sometimes tests will fail because the disk selection is incorrect. This means either MicroCloud is listing disks wrong or LXD is, so this adds a log so we can verify the issue if we run into an error. Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
|
@roosterfish Could this please get a final pass? This is basically just some workarounds to get the microcloud tests to run faster on local systems without needing to wait for the LXD agent in-between snapshot restores. |
masnax
commented
Jun 6, 2024
roosterfish
requested changes
Jun 6, 2024
Makes it easier to catch a freeze Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
…abled We may need to manually remove the zpool in this case. Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.