Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the stunner add-on #223

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Adding the stunner add-on #223

merged 1 commit into from
Apr 17, 2024

Conversation

smeng9
Copy link
Contributor

@smeng9 smeng9 commented Mar 11, 2024

Thank you for making MicroK8s better

Add a new community add-on

Also verify you have:

Copy link
Contributor

@eaudetcobello eaudetcobello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. LGTM.

Copy link
Member

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smeng9, some minor changes needed

addons/stunner/disable Outdated Show resolved Hide resolved
addons/stunner/enable Outdated Show resolved Hide resolved
addons/stunner/enable Outdated Show resolved Hide resolved
@smeng9 smeng9 requested a review from neoaggelos March 13, 2024 00:22
@smeng9
Copy link
Contributor Author

smeng9 commented Mar 19, 2024

Is there any additional changed needed? We could catch the MicroK8s 1.30 release cycle.

@eaudetcobello
Copy link
Contributor

eaudetcobello commented Apr 5, 2024

Is there any additional changed needed? We could catch the MicroK8s 1.30 release cycle.

Hi smeng, I don't think more changes are needed. There is a failing test. I re-ran the job in case it was a flake. Let's see.

@bschimke95
Copy link
Contributor

Hello @smeng9,

It appears that the tests are still failing. You can view the details here: https://github.com/canonical/microk8s-community-addons/actions/runs/8578114130/job/23570692295?pr=223#step:4:290

Additionally, please ensure that you have signed the CLA (Contributor License Agreement). If you have already done so, verify that the name and email associated with your commits match the ones you used to sign the CLA.

Thanks!

@smeng9
Copy link
Contributor Author

smeng9 commented Apr 17, 2024

Hi @bschimke95 Can you help to rerun the tests? I have also fixed the cla.

@smeng9
Copy link
Contributor Author

smeng9 commented Apr 17, 2024

I have redone the cla signing with the users.noreply.github.com email address, fixed linter and skipped strict test.

We can run the GitHub actions again.

@bschimke95
Copy link
Contributor

Please revert the skipping of strict tests. The tests was failing because of an outdated infra branch. That should now work again.

Also, there was a CLA bug that occasionally triggered false positives which was the reason for your CLA check to fail. This is fixed in #228.
Please rebase your branch on main to include that new check.

@smeng9
Copy link
Contributor Author

smeng9 commented Apr 17, 2024

Reverted and Rebased

@bschimke95
Copy link
Contributor

Looks like there is still an issue with the CLA.
I'll investigate and get back to you.

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We fixed the CLA check.
Thanks for your contribution

@bschimke95 bschimke95 merged commit 831293a into canonical:main Apr 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants