-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the stunner add-on #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @smeng9, some minor changes needed
Is there any additional changed needed? We could catch the MicroK8s 1.30 release cycle. |
Hi smeng, I don't think more changes are needed. There is a failing test. I re-ran the job in case it was a flake. Let's see. |
Hello @smeng9, It appears that the tests are still failing. You can view the details here: https://github.com/canonical/microk8s-community-addons/actions/runs/8578114130/job/23570692295?pr=223#step:4:290 Additionally, please ensure that you have signed the CLA (Contributor License Agreement). If you have already done so, verify that the name and email associated with your commits match the ones you used to sign the CLA. Thanks! |
Hi @bschimke95 Can you help to rerun the tests? I have also fixed the cla. |
I have redone the cla signing with the users.noreply.github.com email address, fixed linter and skipped strict test. We can run the GitHub actions again. |
Please revert the skipping of strict tests. The tests was failing because of an outdated infra branch. That should now work again. Also, there was a CLA bug that occasionally triggered false positives which was the reason for your CLA check to fail. This is fixed in #228. |
Reverted and Rebased |
Looks like there is still an issue with the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We fixed the CLA check.
Thanks for your contribution
Thank you for making MicroK8s better
Add a new community add-on
Also verify you have: