Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microk8s add-node --format=short outputs the join command twice #4526

Open
jarbaugh8 opened this issue May 20, 2024 · 1 comment
Open

microk8s add-node --format=short outputs the join command twice #4526

jarbaugh8 opened this issue May 20, 2024 · 1 comment

Comments

@jarbaugh8
Copy link

Summary

The output appears to be duplicated.

$ microk8s add-node --format=short
microk8s join redacted:25000/redacted/redacted
microk8s join redacted:25000/redacted/redacted

What Should Happen Instead?

One line should be output instead of two.

Reproduction Steps

  1. Install MicroK8s v1.28.9 revision 6750
  2. Run microk8s add-node --format=short

Introspection Report

n/a

Are you interested in contributing with a fix?

Not at this time.

@ktsakalozos
Copy link
Member

Thank you for reporting this @jarbaugh8. This is most probably because we print connection strings for both the default interface and all other interfaces [1]

[1] https://github.com/canonical/microk8s/blob/master/scripts/wrappers/add_token.py#L124

ShrishtiKarkera pushed a commit to ShrishtiKarkera/microk8s that referenced this issue Jun 7, 2024
ShrishtiKarkera pushed a commit to ShrishtiKarkera/microk8s that referenced this issue Jun 24, 2024
ShrishtiKarkera added a commit to ShrishtiKarkera/microk8s that referenced this issue Jun 24, 2024
ShrishtiKarkera added a commit to ShrishtiKarkera/microk8s that referenced this issue Jun 26, 2024
tested with unittest (test_addtoken.py)

tested with unittest (test_addtoken.py)

changed and tested add_token.py canonical#4526

changed and tested add_token.py

checked test_multiple for all outputs

changed assertion in test_multiple()

checked lint and cla

checking for lint and cla

checking for cla

checking for cla

checking for cla

checking final

checking final

final push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants