Release 2.16 #3148
Merged
Release 2.16 #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3148 +/- ##
==========================================
+ Coverage 77.81% 77.82% +0.01%
==========================================
Files 1074 1064 -10
Lines 74893 74440 -453
==========================================
- Hits 58275 57933 -342
+ Misses 16618 16507 -111 ☔ View full report in Codecov by Sentry. |
Not all `ConsoleProvider`s will send a `removed` event on the `DeviceObserver` (in fact, only logind will), so we can't rely on that to clean up the handle in `device_watchers`. Furthermore, libinput itself will notice a device going away (by monitoring the fd) and generate `LIBINPUT_EVENT_DEVICE_REMOVED`, which we might process *before* the udev `REMOVED` event, and in *that* case, `device_removed` will have already deleted the `LibInputDevice` and so the udev event handler will *also* not clean up `device_watchers`. Resolve this by cleaning up `device_watchers` *only* in `device_removed`, and rely on the `DeviceObserver::removed` codepath triggering a libinput removal event. Fixes: #3149 (cherry picked from commit 5205713)
|
I've noticed that the changelog is missing at least on PR (#3145):
(I'm leaving this in a comment pending further checking) |
|
@AlanGriffiths we'll need this one cherry-picked: |
(cherry picked from commit cfcf5d0)
~rc5
|
Saviq
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Woot!
Just waiting for things to build in the RC PPA:
https://launchpad.net/~mir-team/+archive/ubuntu/rc/+packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~rc1
TestPlan