Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xwayland] improve handling of CLion subsidiary windows #3145

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

AlanGriffiths
Copy link
Contributor

@AlanGriffiths AlanGriffiths commented Nov 20, 2023

Fixes: #3024, #2326 and #3107

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (aeeb7e8) 77.83% compared to head (bc3b831) 77.82%.
Report is 10 commits behind head on main.

Files Patch % Lines
src/server/frontend_xwayland/xwayland_surface.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3145      +/-   ##
==========================================
- Coverage   77.83%   77.82%   -0.02%     
==========================================
  Files        1074     1064      -10     
  Lines       74867    74433     -434     
==========================================
- Hits        58271    57925     -346     
+ Misses      16596    16508      -88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlanGriffiths AlanGriffiths marked this pull request as ready for review November 21, 2023 12:40
@mattkae mattkae self-requested a review November 21, 2023 15:05
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed:

  • Clion menus being transparent
  • Clion background process menu being transparent
  • Clion settings menu lacking a top bar

And I can't spot anything broken with other X11 apps, so I am happy to approve 👍

@mattkae mattkae added this pull request to the merge queue Nov 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2023
@AlanGriffiths AlanGriffiths added this pull request to the merge queue Nov 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2023
@AlanGriffiths AlanGriffiths added this pull request to the merge queue Nov 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2023
@AlanGriffiths AlanGriffiths merged commit 037ef68 into main Nov 21, 2023
37 checks passed
@AlanGriffiths AlanGriffiths deleted the xwayland-window-types branch November 21, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X11 apps' focus and input transparency wrong with subwindows
2 participants