[qemu] Make create_bridge_with pure virtual.

canonical · May 13, 2024 · 10717b2 · 10717b2
1 parent a783fd5
commit 10717b2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/platform/backends/qemu/qemu_platform.h b/src/platform/backends/qemu/qemu_platform.h
@@ -55,10 +55,7 @@ class QemuPlatform : private DisabledCopyMove
         return {};
     };
     virtual std::vector<NetworkInterfaceInfo> networks() const = 0;
-    virtual std::string create_bridge_with(const std::string& interface) const
-    {
-        return interface;
-    };
+    virtual std::string create_bridge_with(const std::string& interface) const = 0;
 
     virtual std::vector<NetworkInterfaceInfo>::const_iterator
     find_bridge_with(const std::vector<NetworkInterfaceInfo>& networks, const std::string& member_network) const = 0;

diff --git a/tests/qemu/mock_qemu_platform.h b/tests/qemu/mock_qemu_platform.h
@@ -43,6 +43,7 @@ struct MockQemuPlatform : public QemuPlatform
     MOCK_METHOD(QStringList, vm_platform_args, (const VirtualMachineDescription&), (override));
     MOCK_METHOD(QString, get_directory_name, (), (const, override));
     MOCK_METHOD(std::vector<NetworkInterfaceInfo>, networks, (), (const));
+    MOCK_METHOD(std::string, create_bridge_with, (const std::string&), (const, override));
     MOCK_METHOD(std::vector<NetworkInterfaceInfo>::const_iterator,
                 find_bridge_with,
                 (const std::vector<NetworkInterfaceInfo>&, const std::string&),