Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux platform functions to get network interfaces #1811

Closed
wants to merge 18 commits into from
Closed

Linux platform functions to get network interfaces #1811

wants to merge 18 commits into from

Commits on Jan 12, 2021

  1. Improved get_network_interfaces_info() in Linux 

    It still remains to add details on bridges.
    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    a3f3472 View commit details
    Browse the repository at this point in the history

  2. Add bridge and tun/tap interface reporting.

    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    c1acea1 View commit details
    Browse the repository at this point in the history

  3. Expose function to get info from one interface.

    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    19794f2 View commit details
    Browse the repository at this point in the history

  4. Detect USB network devices.

    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    814a2b6 View commit details
    Browse the repository at this point in the history

  5. [networking] Drop obsolete include

    @ricab
    ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    b9fa008 View commit details
    Browse the repository at this point in the history

  6. Avoid using paths forbidden by snapd in Linux.

    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    9490d2d View commit details
    Browse the repository at this point in the history

  7. Test Linux platform::get_network_interface_info(). 

    The test is incomplete, since we still have to mock the filesystem to
mimic reading from /sys.
    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    49c1abf View commit details
    Browse the repository at this point in the history

  8. Linux tests for getting network interfaces info. 

    To test virtual interfaces, the filesystem had to be mocked in order to
create a structure similar to /sys. For physical interfaces, only the
output of the `ip` command had to be simulated.
    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    ea00b5e View commit details
    Browse the repository at this point in the history

  9. Improve Linux network interface detection. Tests.

    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    dff0ce5 View commit details
    Browse the repository at this point in the history

  10. Improve Linux platform functions. 

    Move free functions to unnamed namespace. Add comments about
confinement.

These things were pointed out during the review of the PR.
    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    35ee551 View commit details
    Browse the repository at this point in the history

  11. Remove ip_address from Linux NetworkInterfaceInfo.

    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    cbdf26d View commit details
    Browse the repository at this point in the history

  12. Adapt Linux code after rebase from control-...

    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    c9e4dff View commit details
    Browse the repository at this point in the history

  13. [linux] Improved get_network_interfaces_info(). 

    - Made output strings look like the other platforms output;
- simplified function interfaces;
- add some logging.
    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    6d24c90 View commit details
    Browse the repository at this point in the history

  14. [linux] Updated bridging tests.

    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    a960322 View commit details
    Browse the repository at this point in the history

  15. [linux] Virtual iface detection works now confined.

    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    8a5aff7 View commit details
    Browse the repository at this point in the history

  16. [linux] Distinguish wireless from wired interfaces.

    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    fecd38b View commit details
    Browse the repository at this point in the history

  17. [linux] Use existing function in platform tests.

    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    03bd662 View commit details
    Browse the repository at this point in the history

  18. [linux] Read /proc/net/wireless only once. 

    It was read each time a physical interface was queried.
    @luis4a0 @ricab
    luis4a0 authored and ricab committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    4061178 View commit details
    Browse the repository at this point in the history