Implement support for IPv6 endpoints #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
wolsen
suggested changes
Mar 15, 2024
jedel1043
force-pushed
the
fix-issue-9
branch
2 times, most recently
from
d71387e
to
55eb708
Compare
4 tasks
NucciTheBoss
added
Priority: Medium
|
See my comment here: #10 (comment) |
jedel1043
force-pushed
the
fix-issue-9
branch
4 times, most recently
from
fe3c5d5
to
8485fc0
Compare
4 tasks
Bumps juju@3.1 to pull a version that has support for IPv6. Bumps pytest-operator to avoid using a new version of juju with an old version of pytest-operator.
jedel1043
commented
Mar 26, 2024
NucciTheBoss
requested changes
Mar 27, 2024
|
Edit: See your rebase. Thanks! 👍 |
jedel1043
force-pushed
the
fix-issue-9
branch
2 times, most recently
from
87bf5ae
to
6bf1b97
Compare
This needed some refactoring on the current logic to verify that the host address is enclosed by square brackets, but it's nicer than using a big regex to try to validate at the same time IPv4, IPv6 and registered names.
Uses to mock the filesystem while creating and deleting the autofs files. Adds more tests to have 100% coverage on the manager module.
The most critical thing here is that we have to modify the settings from the lxd network to enable ipv6 addresses. This should probably be fine since we already modify the default LXD profile. Modifies CI to run integration tests using both IPv4 and IPv6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #10.
Also removes our dependencies on regex. We expect this to not be a problem because we should also be validating the URL from the proxy or the relation interface.
Checklist