Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop check-libraries job from CI pipeline #15

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

NucciTheBoss
Copy link
Collaborator

Description

Dropping check-libraries job because (a) we do not use it anywhere else in the HPC charms, and (b) the action does not work if a community contributor opens a merge request from a fork rather than a branch on the same repository.

How was the code tested?

GitHub CI runner

Related issues and/or tasks

Not fixed by #13, and blocks #10, #11, and #12

Checklist

  • I am the author of these changes, or I have the rights to submit them.
  • I have added the relevant changes to the README and/or documentation.
  • I have self reviewed my own code.
  • All requested changes and/or review comments have been resolved.

Dropping check-libraries job because (a) we do not use it anywhere else in the HPC charms, and (b) the action does not work if a community contributor opens a merge request from a fork rather than a branch on the same repository.

Signed-off-by: Jason C. Nucciarone <nuccitheboss@ubuntu.com>
@NucciTheBoss NucciTheBoss added Priority: Critical This should be fixed RIGHT NOW. Should be used only for issues that affect everyone. Type: Bug Issue reports a bug, or pull request fixes a bug. labels Mar 21, 2024
@NucciTheBoss NucciTheBoss merged commit 644f02a into canonical:main Mar 21, 2024
1 check passed
@jedel1043
Copy link
Contributor

The workflow is not valid. .github/workflows/ci.yaml (Line: 55, Col: 9): Job 'integration-test' depends on unknown job 'check-libraries'.

@NucciTheBoss
Copy link
Collaborator Author

The workflow is not valid. .github/workflows/ci.yaml (Line: 55, Col: 9): Job 'integration-test' depends on unknown job 'check-libraries'.

🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical This should be fixed RIGHT NOW. Should be used only for issues that affect everyone. Type: Bug Issue reports a bug, or pull request fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants