rock-pull-request workflow does nothing #125
Comments
artivis
added a commit
to artivis/observability
that referenced
this issue
Nov 29, 2023
Fix canonical#125 Signed-off-by: artivis <jeremie.deray@canonical.com>
|
Thanks for submitting the issue and the PR! I'll be on it right away :) |
artivis
added a commit
to artivis/observability
that referenced
this issue
Dec 1, 2023
Fix canonical#125 Signed-off-by: artivis <jeremie.deray@canonical.com>
simskij
pushed a commit
that referenced
this issue
Dec 1, 2023
Fix #125 Signed-off-by: artivis <jeremie.deray@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
rock-pull-requestworkflow does nothing.The reason is that it relies on the
tj-actions/changed-filesaction to get a list of all modifiedrockcraft.yamlfiles but then uses the wrong output variable from this action. It useschanged_files-- which was renamed a while back totype_changed_files-- which gets the list of files which extension have been changed.This results in an empty list, which is happily and successfully iterated over by the job resulting in a happy CI.
The text was updated successfully, but these errors were encountered: