Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _rock-build-test workflow #126

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

artivis
Copy link
Contributor

@artivis artivis commented Nov 29, 2023

Fix #125

@simskij
Copy link
Member

simskij commented Dec 1, 2023

@artivis can you please amend your commit and sign it so that we can merge it?

@artivis
Copy link
Contributor Author

artivis commented Dec 1, 2023

@artivis can you please amend your commit and sign it so that we can merge it?

@simskij I'm not sure to understand, the commit is signed (Signed-off-by: artivis <jeremie.deray@canonical.com>). Is there something more to do?

@simskij
Copy link
Member

simskij commented Dec 1, 2023

@artivis can you please amend your commit and sign it so that we can merge it?

@simskij I'm not sure to understand, the commit is signed (Signed-off-by: artivis <jeremie.deray@canonical.com>). Is there something more to do?

I'll contact you directly , but basically, we need a gpg-sign (-S) as opposed to a Signed-off-by message (-s).

  Fix canonical#125

Signed-off-by: artivis <jeremie.deray@canonical.com>
@artivis
Copy link
Contributor Author

artivis commented Dec 1, 2023

I'll contact you directly , but basically, we need a gpg-sign (-S) as opposed to a Signed-off-by message (-s).

I got that green tick on the commit ;)

@simskij simskij merged commit 3de4a83 into canonical:main Dec 1, 2023
@artivis artivis deleted the fix/_rock-build-test branch December 1, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rock-pull-request workflow does nothing
3 participants