merge fixes for rock from ckf-1.7 to main
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, the rock's workload would not start, instead crashing on: > level=fatal msg="open web/templates/default: no such file or directory" because the web files were not copied to the working directory. This commit refactors the rock and the working directory to be identical to the upstream docker image
ca-scribner
force-pushed
the
KF-5232-pull-ckf-1.7-to-main
branch
from
1157e62
to
4d5e1a7
Compare
DnPlas
reviewed
Jan 19, 2024
DnPlas
approved these changes
Jan 22, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges fixes to the oidc-authservice rock from 1.7 back to main, so they can be reused for future versions.
Also included are fixes to the tests in main that are required for this updated rock
Closes #21