[DPE-4191] Release pipeline fixed #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
approved these changes
Apr 23, 2024
Comment on lines
67
to
-70
| matrix: | ||
| path: | ||
| - . | ||
| # - tests/integration/app-charm |
There was a problem hiding this comment.
nit: matrix can be removed entirely
There was a problem hiding this comment.
i'm wondering if for traefik integration tests it may come handy to have a little test charm. (As we won't be able to test against the real, cross-model system in the tests).
If I won't need it still, I'll remove it then!
There was a problem hiding this comment.
Refeence added to the [DPE-3954] Final cleanup ticket
Mehdi-Bendriss
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the release pipeline is not functional: https://github.com/canonical/opensearch-dashboards-operator/actions/runs/8796263733
As @carlcsaposs-canonical advised, the write permssion requests in the Release pipeline were not needed here.